Skip to content

Use adjusted local date for civil time calculation#263

Merged
KosherJava merged 1 commit into
KosherJava:3-0-modernizationfrom
dickermoshe:patch-4
Apr 28, 2026
Merged

Use adjusted local date for civil time calculation#263
KosherJava merged 1 commit into
KosherJava:3-0-modernizationfrom
dickermoshe:patch-4

Conversation

@dickermoshe

Copy link
Copy Markdown
Contributor

This fixes an issue where the returned time was 24 hours off.

Test Case:

{
    "iteration": 741,
    "year": 2058,
    "month": 7,
    "day": 31,
    "latitude": -18.88480386694347,
    "longitude": -174.522379072958,
    "elevation": 2671.332842032057,
    "timezone": "Pacific/Tongatapu",
    "zman": "getFixedLocalChatzos",
    "ateretTorahSunsetOffsetMinutes": 19,
    "candleLightingOffsetMinutes": 6,
    "useAstronomicalChatzosForOtherZmanim": true,
    "useElevation": false
  }

@KosherJava KosherJava left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dickermoshe - Looks good.

@KosherJava KosherJava merged commit 023a362 into KosherJava:3-0-modernization Apr 28, 2026
1 check passed
binyaz pushed a commit to binyaz/zmanim that referenced this pull request Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants