Various bug fixes and improvements to the 3.0 migration.#261
Merged
Conversation
…e correct SUNRISE enum in getInstantFromTime
Fix javadoc on `isUseElevation`
- Remove zmanim which are no longer in KJ - Pass correct args to `getMinchaGedolaGreaterThan30`
- Update docs on `getLocalMeanTimeOffset` to reflect changes made in earlier commits. We now return the actual offset instead the "Standard Offset" - `setLongitude` was not validating the correct variable. This has been fixes. - Remove unnecessary variable instantiation. - Remove timezone offset from toXML and toString. - Use the dedicated methods for Long.hashCode. - Remove unnecessary casting.
- Use dedicated Long.compare instead of hand-rolled comparator. - Add null checking to toXML and to toString.
- `getTime` will properly return a negative time.
- Automated code fixes by IntelliJ to simplify the return values.
- Remove unnecessary variables. - Implement hashCode and equal method.
Most of these improvements were automated by IntelliJ. - Mark final fields with the `final` keyword. - Removed unused commented code. - Format negative times properly. - Use the modern for loop. - Remove unnecessary casting. - Convert integer values to long before casting. - Break out duplicated if checks into variables.
- Fix the off-by-a-second bug. - Fix getLocalMeanTime to use a local time class instead of a double. - No longer use getInstantFromTime in getLocalMeanTime. - Implement strict equals on the `equal` function. - Equality and hashCode now properly take into account the various fields of the calendar.
- Use `Double.hashCode` instead of complex alternatives.
- Update `getFixedLocalChatzos` to use the correct arguments for getLocalMeanTime - Remove unnecessary variable instantiations.
- Remove unnecessary and variable instantiations. - Implement hashCode and equals properly.
- Use the correct variable names in duration comparator. - Set a time zone for the DateTimeFormatter in toXML.
…java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
KosherJava
approved these changes
Mar 23, 2026
KosherJava
left a comment
KosherJava
left a comment
Owner
There was a problem hiding this comment.
Looks good. Committing for testing
binyaz
pushed a commit
to binyaz/zmanim
that referenced
this pull request
Jun 28, 2026
) * Migrate AstronomicalCalendar to use LocalDate - Fix Timezone Bug - Use correct SUNRISE enum in getInstantFromTime * Fix Javadocs * Rename getSunrise to getSunriseWithElevation. Fix javadoc on `isUseElevation` * Rename getElevationAdjustedSunset/rise to avoid further confusion. * Fix incorrect adjustment for getFixedLocalChatzos * Update date * revert * implement jewishdate * some eq changes * nuller * fix formaterr, etc. * more changes * configure addYears * more date changes * Fix molad * Modifying a JewishDate no longer resets the molad date * add est jewish month * Remove get local mean time fix. * Fix RegressionTestFileWriter - Remove zmanim which are no longer in KJ - Pass correct args to `getMinchaGedolaGreaterThan30` * Fix Geolocation - Update docs on `getLocalMeanTimeOffset` to reflect changes made in earlier commits. We now return the actual offset instead the "Standard Offset" - `setLongitude` was not validating the correct variable. This has been fixes. - Remove unnecessary variable instantiation. - Remove timezone offset from toXML and toString. - Use the dedicated methods for Long.hashCode. - Remove unnecessary casting. * Add .class files to the.gitignore. * Remove unnecessary variable instantiation on HebrewDateFormatter. * Fixes for Zman class. - Use dedicated Long.compare instead of hand-rolled comparator. - Add null checking to toXML and to toString. * Fixed Time class - `getTime` will properly return a negative time. * Simplify TefilaRules - Automated code fixes by IntelliJ to simplify the return values. * Improvements to AstronomicalCalculator - Remove unnecessary variables. - Implement hashCode and equal method. * Remove unnecessary imports from YomiCalculator * Improvements to ZmanimFormatter Most of these improvements were automated by IntelliJ. - Mark final fields with the `final` keyword. - Removed unused commented code. - Format negative times properly. - Use the modern for loop. - Remove unnecessary casting. - Convert integer values to long before casting. - Break out duplicated if checks into variables. * Improvements to AstronomicalCalendar. - Fix the off-by-a-second bug. - Fix getLocalMeanTime to use a local time class instead of a double. - No longer use getInstantFromTime in getLocalMeanTime. - Implement strict equals on the `equal` function. - Equality and hashCode now properly take into account the various fields of the calendar. * Remove unnecessary variables from NOAACalculator * Improve AstronomicalCalculator - Use `Double.hashCode` instead of complex alternatives. * Improve ComprehensiveZmanimCalendar - Update `getFixedLocalChatzos` to use the correct arguments for getLocalMeanTime - Remove unnecessary variable instantiations. * Improve ZmanimCalendar - Remove unnecessary and variable instantiations. - Implement hashCode and equals properly. * Fix Zman class. - Use the correct variable names in duration comparator. - Set a time zone for the DateTimeFormatter in toXML. * Fix JewishDate tests. * Add various regression tests * Update src/main/java/com/kosherjava/zmanim/hebrewcalendar/JewishDate.java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update src/main/java/com/kosherjava/zmanim/hebrewcalendar/JewishDate.java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update src/main/java/com/kosherjava/zmanim/hebrewcalendar/JewishDate.java Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have broken this up into neatly sectioned commits to make it easier to review.
Each commit it is focused on a single file and details all the changes that were made.