Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29254658 | Triggered | Generic High Entropy Secret | 22f8a0b | tests/config_tests.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add full test suite, library target, and CI pipeline improvements
Summary
src/lib.rsto expose the crate as a library sotests/can import public APIsCargo.tomlwith the[lib]target and[dev-dependencies].github/workflows/ci.ymlwith per-suite test steps,devbranch trigger, and additional integration smoke checksupdates.mdwith a versioned feature roadmap for future developmentcargo fmtandcargo clippy -D warningsare both cleanrustyochestratoritself — all 19 tasks passed, with smart cache hits on repeated runsWhat changed
src/lib.rs(new)Exposes all 10 source modules (
cache,cli,config,errors,executor,github,pipeline,reporter,scheduler,tui) aspub moddeclarations. This makes the crate a dual binary+library target so integration tests intests/can import from it withuse rustyochestrator::*.tests/(new — 8 files, 110 tests, ~1600 lines)pipeline_tests.rslevels(), SHA-256 hashing,TaskStategithub_tests.rsneeds(string + array), sequential steps, env precedence (workflow → job → step), secret ref preservation,${{ }}expression filteringcache_tests.rsexecutor_tests.rsscheduler_tests.rsreporter_tests.rsEventvariants, JSONtypetag (snake_case), ISO 8601 timestamp format, field completenesserrors_tests.rsRustyErrorvariants,Fromconversions (io::Error,serde_yaml::Error,serde_json::Error),Resulttype aliasconfig_tests.rsConnectConfigJSON round-trip, clone,Debugformat, deserialization from raw JSONCargo.toml.github/workflows/ci.ymldevto the push trigger branches so CI runs on this branchtestjob to run each test suite as a named step (cargo test --test <suite>) for clear per-suite pass/fail visibility in the GitHub Actions UIvalidate,list,graph, andinit+ validateintegrationjob cache-hit assertion comment (was "expected 4 cache hits", now reflects the correct 7)updates.md(new)Versioned feature roadmap (v0.2–v0.7) covering: task timeouts, configurable retries, output capture, conditional execution, GitHub Actions matrix/
if:/context support, structured run reports, pipeline resumption, webhook triggers, remote cache backend, Windows support, and a plugin/hook system.How it was tested
The pipeline run also caught two real issues in the test files that were fixed before merging:
cargo fmtflagged long method chains that needed reformattingclippy -D warningsflagged.get(...).is_none()(use.contains_key(...)) andunwrap()on a literalOkvalueChecklist
cargo fmt --checkpassescargo clippy -D warningspassescargo build --releasepassesrustyochestrator run .github/workflows/ci.ymlunwrap()calls in production code