Conversation
The templating option, its helper and its service file have carried a deprecation since 3.3 announcing their removal in version 4, and master is already that major: it dropped Symfony 5 and PHP 8.1. symfony/templating goes with it, since nothing else used it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501
The templating integration has announced its own removal since 3.3, both in code and in the docs:
masteris that major already, having dropped Symfony 5 in #500 and PHP 8.1 in #506, so this takes it out: thetemplatingoption, the helper, its service file, the XSD attribute, thesymfony/templatingdev dependency that nothing else used, the tests and the documentation.That is the second half of what @tacman asked for in the issue. The first half, the Symfony 8 bump, landed with those two PRs.
Test suite: 26 tests green, against 36 on
master. The difference is the ten tests that covered the removed feature, and the PHPUnit deprecations drop from 12 to 4 with the legacy ones gone.