fix: use padding for title bar drag region#71
Open
valipuha wants to merge 1 commit into
Open
Conversation
Adjust the desktop title bar spacing so the top 4px is inside the title bar element instead of outside it. This preserves the visual offset while restoring a proper Electron drag region for themed Discord windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the desktop title bar spacing so the top 4px is applied as padding instead of margin.
Root cause
Electron window dragging only works inside the draggable element box. When the top spacing sits outside that box as margin, the top edge can stop behaving like a drag region.
Changes
margin: 0padding-top: 4pxto preserve the same visual spacingValidation
origin/mastergit diff --checksuccessfullyNotes
This repo does not include automated UI tests, so final confirmation should be done in the Discord desktop app on Windows/Electron.