fix out-of-bounds read on empty block in layoutObjectCheck#4306
Merged
arcady-lunarg merged 1 commit intoJul 2, 2026
Conversation
Contributor
Author
|
gentle ping |
arcady-lunarg
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASan, Vulkan/SPIR-V target, tessellation-control stage:
Redeclaring a built-in block with an instance name and members that don't match
the originals erases every original member (the instance-name erase in
redeclareBuiltinBlock), so the block is left with an empty member list.
layoutObjectCheck then reads member [0] to inspect its location qualifier, past
the end of an empty list. Skip the member check when the block has no members.
Repro:
compiled for a tesc stage with a Vulkan target.