Fix flat interpolation check on fs inputs qualified with perPrimitiveNV#4050
Open
dreamelon wants to merge 1 commit into
Open
Fix flat interpolation check on fs inputs qualified with perPrimitiveNV#4050dreamelon wants to merge 1 commit into
dreamelon wants to merge 1 commit into
Conversation
Author
|
Ping for review |
dnovillo
requested changes
May 14, 2026
dnovillo
left a comment
Collaborator
There was a problem hiding this comment.
The fix itself LGTM, but this needs a test. Please add a test that exercises this path. Maybe something like
#version 450
#extension GL_NV_mesh_shader : require
layout(location = 0) perprimitiveNV in int idx;
layout(location = 0) out vec4 fragColor;
void main() { fragColor = vec4(float(idx)); }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec allows any interpolation qualifier on fragment shader inputs qualified with "perprimitiveNV".
https://github.com/KhronosGroup/GLSL/blob/d368fe808d7e11476945901120510edbe490f961/extensions/nv/GLSL_NV_mesh_shader.txt#L1119