add search disable while waiting for index to arrive.#210
Merged
marty-johnson59 merged 2 commits intoJun 15, 2026
Merged
Conversation
Closed
|
Preview site published: https://KhronosGroup.github.io/Vulkan-Site/PR-210/ |
Collaborator
|
I looked at this in Chromium incognito mode, which should defeat search index caching, and did see the searchbox blocked for a few seconds. That's all the testing I can do so I approve. |
Collaborator
|
I can confirm that I see the "loading index" in the search box by using Chrome's built-in throttling. But the search results seem to be completely broken. The search now seems to spit out whole chapter texts on search requests: 
This brings even my desktop PC to a crawl while searching. |
Collaborator
Author
|
Ahh... thanks, I'll look at that. |
…k in search-ui.js (line 312)
SaschaWillems
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to disable or at least warn about search not being ready while downloading a new index.