Convert Expression to functional component and improve testing and typing by Myranae · Pull Request #3157 · Khan/perseus

Myranae · 2025-12-19T18:48:25Z

Summary:

This pull request refactors the Expression widget from a class-based component to a modern functional component using React hooks. This conversion improves the long-term maintainability of the component by aligning it with current React best practices, making the code easier to read and reason about. The test suite for the widget has also been significantly expanded with more comprehensive and robust tests, covering accessibility, focus management, and programmatic content insertion to prevent future regressions.

Key technical improvements include a more robust focus management system that handles edge cases gracefully, especially on mobile. A new wrapper component was introduced to create a stable interface for the underlying math input component, resolving previous fragility. Additionally, the Storybook stories and test data have been updated for better clarity and descriptiveness, making it easier for future engineers to understand and work with the component.

Summary: Gemini
Code: Claude
Reviews: Codex, Claude, Gemini

Issue: LEMS-3804

Test plan:

Confirm all tests pass
Confirm widget functions the same with Storybook and ZND testing

…stories

…comments

Reuse actual DOM target instead of dynamically-assigned textarea ID, ensuring focus() returns a truthful result even before the ID is set or when focus was already correct.

To cover focus() behavior when the input lacks an ID and to verify insert() works immediately after mount without prior focus.

…s PR Make more type safe by referencing Widget type

…nterface

…anuary-2026' into tb/LEMS-3804/expression-conversion-2

…ssion to functional component and improve testing and typing

github-actions · 2025-12-19T18:49:07Z

🗄️ Schema Change: No Changes ✅

github-actions · 2025-12-19T18:49:35Z

Size Change: +256 B (+0.05%)

Total Size: 487 kB

Filename	Size	Change
`packages/perseus/dist/es/index.js`	192 kB	+256 B (+0.13%)

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	20.8 kB
`packages/keypad-context/dist/es/index.js`	1 kB
`packages/kmath/dist/es/index.js`	5.98 kB
`packages/math-input/dist/es/index.js`	98.5 kB
`packages/math-input/dist/es/strings.js`	1.61 kB
`packages/perseus-core/dist/es/index.item-splitting.js`	12.1 kB
`packages/perseus-core/dist/es/index.js`	25 kB
`packages/perseus-editor/dist/es/index.js`	96.7 kB
`packages/perseus-linter/dist/es/index.js`	8.65 kB
`packages/perseus-score/dist/es/index.js`	9.25 kB
`packages/perseus-utils/dist/es/index.js`	403 B
`packages/perseus/dist/es/strings.js`	7.44 kB
`packages/pure-markdown/dist/es/index.js`	1.39 kB
`packages/simple-markdown/dist/es/index.js`	6.71 kB

_{compressed-size-action}

github-actions · 2025-12-19T18:49:44Z

🛠️ Item Splitting: No Changes ✅

github-actions · 2025-12-19T18:50:33Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (f887a1a) and published it to npm. You
can install it using the tag PR3157.

Example:

pnpm add @khanacademy/perseus@PR3157

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3157

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3157

…e planning docs

Myranae · 2025-12-19T19:00:37Z

Small TS fix for something I missed in the previous conversion PR

Change one to be wrapped by renderer, remove unneeded story toggling answer visibility, remove answerless story

…s to be descriptive

Myranae · 2026-01-06T15:01:17Z

-
-/** This story shows how the expression widget looks when the keypad is
- * configured with _every_ option it supports.  */
-// TODO: use a Renderer wrapper rather than rendering this directly
-export const ShowAnswerButton = (): React.ReactElement => {
-    const [showAnswer, setShowAnswer] = React.useState(true);
-    return (
-        <div style={{padding: "2rem"}}>
-            <label>
-                <input
-                    type="checkbox"
-                    checked={showAnswer}
-                    onChange={() => setShowAnswer(!showAnswer)}
-                />
-                Show answer
-            </label>
-            <ServerItemRendererWithDebugUI
-                item={showAnswer ? expressionItem4Static : expressionItem4}
-            />
-        </div>
-    );
-};


The comment had been updated incorrectly. This was for showing static using a checkbox. Since we now have a static story (which can change back and forth using the Perseus JSON if needed), I got rid of this one.

Myranae · 2026-01-06T15:05:14Z

+        }),
+    );
+
+export const expressionItemKitchenSink: PerseusItem = createExpressionItemJson(


This is actually a new testdata item, but for some reason it's being compared to the static data item in the PR. Only the name of the static data item changed and this one is just added after it.

Myranae · 2026-01-06T15:11:33Z

There are a number of new tests that Claude recommended. Not sure if all of them are useful, though they sounded useful at the time. Let me know if any are unnecessary and just take up time. I think most are the cover the new KeypadInputWithInterface wrapper functionality.

… disabled stories The story called for a button that wasn't there in the keypad, so just had to add the right buttons to the test data

anakaren-rojas

Great work on the conversion!
I noticed this uses a nested wrapper pattern that differs from our other recently-converted widgets, which call useDependencies() directly.
Was there a specific reason for the extra wrapper? If not, for consistency sake, can you simplify to match the pattern used in the modernized widgets?

It's okay and probably wanted for there to be an editor error for this widget in the associated stories

…ndencies

Myranae · 2026-01-07T21:23:51Z

Great work on the conversion! I noticed this uses a nested wrapper pattern that differs from our other recently-converted widgets, which call useDependencies() directly. Was there a specific reason for the extra wrapper? If not, for consistency sake, can you simplify to match the pattern used in the modernized widgets?

Thanks for pointing this out, @anakaren-rojas! I believe I've updated this to match other functional components now (doesn't use the wrapper for analytics, uses useDependencies()).

anakaren-rojas

What an undertaking! Great job!

jeremywiebe

Very cool!! Thanks for switching this over! One less class!!!

… review

…MS-3804/expression-conversion-2

@benchristel

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@74.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels ### Patch Changes - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/perseus-core@23.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. ### Minor Changes - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing ## @khanacademy/perseus-editor@28.10.0 ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor ### Patch Changes - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/keypad-context@3.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/kmath@2.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/math-input@26.3.10 ### Patch Changes - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 ## @khanacademy/perseus-linter@4.6.12 ### Patch Changes - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 ## @khanacademy/perseus-score@8.2.6 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187

@benchristel

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@74.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels ### Patch Changes - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/perseus-core@23.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. ### Minor Changes - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing ## @khanacademy/perseus-editor@28.10.0 ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor ### Patch Changes - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/keypad-context@3.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/kmath@2.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/math-input@26.3.10 ### Patch Changes - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 ## @khanacademy/perseus-linter@4.6.12 ### Patch Changes - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 ## @khanacademy/perseus-score@8.2.6 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187

…ping (#3157) ## Summary: This pull request refactors the Expression widget from a class-based component to a modern functional component using React hooks. This conversion improves the long-term maintainability of the component by aligning it with current React best practices, making the code easier to read and reason about. The test suite for the widget has also been significantly expanded with more comprehensive and robust tests, covering accessibility, focus management, and programmatic content insertion to prevent future regressions. Key technical improvements include a more robust focus management system that handles edge cases gracefully, especially on mobile. A new wrapper component was introduced to create a stable interface for the underlying math input component, resolving previous fragility. Additionally, the Storybook stories and test data have been updated for better clarity and descriptiveness, making it easier for future engineers to understand and work with the component. _Summary: Gemini Code: Claude Reviews: Codex, Claude, Gemini_ Issue: LEMS-3804 ## Test plan: - Confirm all tests pass - Confirm widget functions the same with Storybook and ZND testing Author: Myranae Reviewers: Myranae, anakaren-rojas, jeremywiebe, nishasy, catandthemachines Required Reviewers: Approved By: anakaren-rojas, jeremywiebe Checks: ✅ 10 checks were successful, ⏭️ 1 check has been skipped Pull Request URL: #3157

@benchristel

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@74.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels ### Patch Changes - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/perseus-core@23.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. ### Minor Changes - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing ## @khanacademy/perseus-editor@28.10.0 ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor ### Patch Changes - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/keypad-context@3.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/kmath@2.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/math-input@26.3.10 ### Patch Changes - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 ## @khanacademy/perseus-linter@4.6.12 ### Patch Changes - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 ## @khanacademy/perseus-score@8.2.6 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187

@benchristel

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187

Myranae added 15 commits December 18, 2025 10:06

[tb/LEMS-3804/expression-conversion-2] Add plan and research docs

94c613f

[tb/LEMS-3804/expression-conversion-2] Convert expression and update …

ed2ea3e

…stories

[tb/LEMS-3804/expression-conversion-2] Fix for keypadinput insert issue

e473583

[tb/LEMS-3804/expression-conversion-2] Fix lint error

0a8f9bc

[tb/LEMS-3804/expression-conversion-2] Fix some focus issues and add …

30c5406

…comments

[tb/LEMS-3804/expression-conversion-2] Add test for aria label

8b2aeb6

[tb/LEMS-3804/expression-conversion-2] Update focus

4a50a1f

Reuse actual DOM target instead of dynamically-assigned textarea ID, ensuring focus() returns a truthful result even before the ID is set or when focus was already correct.

[tb/LEMS-3804/expression-conversion-2] Add regression tests

800c84c

To cover focus() behavior when the input lacks an ID and to verify insert() works immediately after mount without prior focus.

[tb/LEMS-3804/expression-conversion-2] Fix Dropdown type from previou…

65d911f

…s PR Make more type safe by referencing Widget type

[tb/LEMS-3804/expression-conversion-2] Lint fix

c0026b3

[tb/LEMS-3804/expression-conversion-2] Add tests for keypadInputWithI…

a2bf54d

…nterface

[tb/LEMS-3804/expression-conversion-2] Add a comment and a guard

903c5cb

[tb/LEMS-3804/expression-conversion-2] Improve types and add test

2a6c993

[tb/LEMS-3804/expression-conversion-2] Merge branch 'deploy/perseus-j…

a3af6c3

…anuary-2026' into tb/LEMS-3804/expression-conversion-2

[tb/LEMS-3804/expression-conversion-2] docs(changeset): Convert Expre…

bcc6ccb

…ssion to functional component and improve testing and typing

Myranae self-assigned this Dec 19, 2025

Myranae added the olc-5.0.07850 label Dec 19, 2025

[tb/LEMS-3804/expression-conversion-2] Small simplification and remov…

bba05f4

…e planning docs

Myranae commented Dec 19, 2025

View reviewed changes

Myranae added 4 commits December 19, 2025 15:20

[tb/LEMS-3804/expression-conversion-2] Update test names

6911364

[tb/LEMS-3804/expression-conversion-2] Clean up stories

5bb1c32

Change one to be wrapped by renderer, remove unneeded story toggling answer visibility, remove answerless story

[tb/LEMS-3804/expression-conversion-2] Update story and testdata name…

0c8da86

…s to be descriptive

[tb/LEMS-3804/expression-conversion-2] Remove unneeded comment

069f9a4

Myranae commented Jan 6, 2026

View reviewed changes

Myranae requested review from a team and catandthemachines January 6, 2026 17:22

[tb/LEMS-3804/expression-conversion-2] Fix an error related to editor…

4c05d88

… disabled stories The story called for a button that wasn't there in the keypad, so just had to add the right buttons to the test data

anakaren-rojas reviewed Jan 6, 2026

View reviewed changes

Myranae added 2 commits January 7, 2026 14:27

[tb/LEMS-3804/expression-conversion-2] Revert unneeded fix

297225e

It's okay and probably wanted for there to be an editor error for this widget in the associated stories

[tb/LEMS-3804/expression-conversion-2] Switch from wrapper to useDepe…

9d68139

…ndencies

Myranae requested a review from anakaren-rojas January 7, 2026 21:24

github-actions Bot added item-splitting-change and removed item-splitting-change labels Jan 7, 2026

anakaren-rojas approved these changes Jan 7, 2026

View reviewed changes

Base automatically changed from deploy/perseus-january-2026 to main January 8, 2026 20:15

jeremywiebe approved these changes Jan 8, 2026

View reviewed changes

Myranae added 5 commits January 9, 2026 10:12

[tb/LEMS-3804/expression-conversion-2] First batch of updates from PR…

d55b4ed

… review

[tb/LEMS-3804/expression-conversion-2] Small updates from PR comments

7d6d859

[tb/LEMS-3804/expression-conversion-2] Add additional point to CLAUDE.md

3acc54f

[tb/LEMS-3804/expression-conversion-2] Remove unused import

93b764b

[tb/LEMS-3804/expression-conversion-2] Merge branch 'main' into tb/LE…

f801532

…MS-3804/expression-conversion-2

Myranae requested a review from jeremywiebe January 9, 2026 22:01

jeremywiebe approved these changes Jan 9, 2026

View reviewed changes

Myranae added 2 commits January 15, 2026 10:13

[tb/LEMS-3804/expression-conversion-2] Merge branch 'main' into tb/LE…

0afd33e

…MS-3804/expression-conversion-2

[tb/LEMS-3804/expression-conversion-2] Merge branch 'main' into tb/LE…

f887a1a

…MS-3804/expression-conversion-2

Myranae merged commit 9cba519 into main Jan 21, 2026
11 checks passed

Myranae deleted the tb/LEMS-3804/expression-conversion-2 branch January 21, 2026 17:17

khan-actions-bot mentioned this pull request Jan 20, 2026

Version Packages #3187

Merged

Conversation

Myranae commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Test plan:

Uh oh!

github-actions Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗄️ Schema Change: No Changes ✅

Uh oh!

github-actions Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠️ Item Splitting: No Changes ✅

Uh oh!

github-actions Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

npm Snapshot: Published

Uh oh!

Myranae Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Myranae Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Myranae Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Myranae Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anakaren-rojas left a comment

Choose a reason for hiding this comment

Uh oh!

Myranae commented Jan 7, 2026

Uh oh!

anakaren-rojas left a comment

Choose a reason for hiding this comment

Uh oh!

jeremywiebe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Myranae commented Dec 19, 2025 •

edited

Loading

github-actions Bot commented Dec 19, 2025 •

edited

Loading

github-actions Bot commented Dec 19, 2025 •

edited

Loading

github-actions Bot commented Dec 19, 2025 •

edited

Loading

github-actions Bot commented Dec 19, 2025 •

edited

Loading

Myranae Jan 6, 2026 •

edited

Loading