Skip to content

DO NOT MERGE - Debugging insertBefore #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mark-fitzgerald wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE - Debugging insertBefore #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9873bb
[temp/debug-insertBefore-error] Add console messages for debugging.
mark-fitzgerald Nov 20, 2025
66d440c
[temp/debug-insertBefore-error] Merge branch 'main' into temp/debug-i…
mark-fitzgerald Nov 20, 2025
98440a1
[temp/debug-insertBefore-error] disable lint messages for debugging
mark-fitzgerald Nov 20, 2025
98a2857
[temp/debug-insertBefore-error] docs(changeset):
mark-fitzgerald Nov 20, 2025
4299f48
[temp/debug-insertBefore-error] docs(changeset): DEBUG - Console mess…
mark-fitzgerald Nov 20, 2025
7e3d4bb
[temp/debug-insertBefore-error] Try a possible translation bug fix.
mark-fitzgerald Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/shiny-mugs-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/perseus": patch
"raphael": patch
---

DEBUG - Console messaages for debugging insertBefore error
2 changes: 2 additions & 0 deletions packages/perseus/src/interactive2/wrapped-drawing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export default abstract class WrappedDrawing {
toBack() {
const parentNode = this.wrapper.parentNode;
if (parentNode != null && parentNode.firstChild !== this.wrapper) {
// eslint-disable-next-line
console.log("*** insertBefore - wrapped-drawing.ts ***");
parentNode.insertBefore(this.wrapper, parentNode.firstChild);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus/src/widgets/radio/choice-indicator.new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const Indicator = (props: IndicatorProps) => {
onClick={handleClick}
>
{icon}
{content.visible}
<span>{content.visible}</span>
</button>
);
};
Expand Down
14 changes: 14 additions & 0 deletions vendor/raphael/raphael.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,6 +1668,8 @@ export default (function () {
return this;
}
if (this.node.parentNode.firstChild != this.node) {
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 1 ***");
this.node.parentNode.insertBefore(this.node, this.node.parentNode.firstChild);
toback(this, this.paper);
var svg = this.paper;
Expand All @@ -1680,6 +1682,8 @@ export default (function () {
}
var node = element.node || element[element.length - 1].node;
if (node.nextSibling) {
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 2 ***");
node.parentNode.insertBefore(this.node, node.nextSibling);
} else {
node.parentNode[appendChild](this.node);
Expand All @@ -1692,6 +1696,8 @@ export default (function () {
return this;
}
var node = element.node || element[0].node;
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 3 ***");
node.parentNode.insertBefore(this.node, node);
insertbefore(this, element, this.paper);
return this;
Expand Down Expand Up @@ -1955,6 +1961,8 @@ export default (function () {
dstyle.left = 0;
dstyle.width = o.paper.width + "px";
dstyle.height = o.paper.height + "px";
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 4 ***");
group.parentNode.insertBefore(div, group);
div[appendChild](group);
node.clipRect = div;
Expand Down Expand Up @@ -2398,6 +2406,8 @@ export default (function () {
return this;
}
if (this.Group.parentNode.firstChild != this.Group) {
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 5 ***");
this.Group.parentNode.insertBefore(this.Group, this.Group.parentNode.firstChild);
toback(this, this.paper);
}
Expand All @@ -2411,6 +2421,8 @@ export default (function () {
element = element[element.length - 1];
}
if (element.Group.nextSibling) {
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 6 ***");
element.Group.parentNode.insertBefore(this.Group, element.Group.nextSibling);
} else {
element.Group.parentNode[appendChild](this.Group);
Expand All @@ -2425,6 +2437,8 @@ export default (function () {
if (element.constructor == Set) {
element = element[0];
}
// eslint-disable-next-line
console.log("*** insertBefore - raphael - 7 ***");
element.Group.parentNode.insertBefore(this.Group, element.Group);
insertbefore(this, element, this.paper);
return this;
Expand Down
Loading