KC-1446: Add shell-specific password validation to prevent command injection - #2339
Merged
amangalampalli-ks merged 4 commits intoSep 3, 2026
Conversation
sali-ks
approved these changes
Sep 3, 2026
amangalampalli-ks
force-pushed
the
fix/shell-password-validation-int
branch
from
September 3, 2026 13:22
7f80e1b to
9d42eb1
Compare
amangalampalli-ks
force-pushed
the
fix/shell-password-validation
branch
from
September 3, 2026 13:22
26d0449 to
d8f7f7f
Compare
amangalampalli-ks
merged commit Sep 3, 2026
5f14ac6
into
fix/shell-password-validation
2 checks passed
sk-keeper
pushed a commit
that referenced
this pull request
Sep 3, 2026
…jection (#2339) * Add shell-specific password validation to prevent command injection * Add backward compatibility * Fix review comments * Add unixpasswd in the ssh list and white space in regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SSH Windows password rotation command injection
Summary
SSH password rotation on Windows machines was vulnerable to command injection through special characters in passwords and usernames.
Changes
&,$,(), whitespace, etc.) for SSH, PSPasswd & Unix password plugins