Match shared folder by UID in import - #2334
Open
lthievenaz-keeper wants to merge 3 commits into
Open
Conversation
Add unsafe flag and manual documentation. Unsafe flag allows the apply-membership to remove yourself from the folders if set.
Currently, apply-membership --full-sync will remove folder permissions so that it matches the JSON file, however it won't remove yourself. Added --unsafe flag, which will allow removing yourself if you're not set on the folder permissions. This can be useful: - If the folder is only meant to be shared to your team and not you. - To reproduce enterprise-push behavior with shared folders at scale
In import (e.g. JSON), shared folders are matched by path, not UID. If a vault has a shared folder with the same UID, but different path (e.g. the shared folder is nested in a personal folder), the import will create a new shared folder. This changes the import process so that if the import includes a UID which matches that of a shared folder in the vault, the folder will not be duplicated. If the path is different, the existing folder will be moved to the new path. Currently only wired up for Classic folders, awaiting the upcoming NSF folder-move API (Keeper-Security#2324) to apply this to NSF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of PR #2326 (--unsafe flag for apply-membership)
During an import (e.g. JSON), shared folders are matched by path, not UID.
If a vault has a shared folder with the same UID, but different path (e.g. the shared folder is nested in a personal folder), the import will create a new shared folder.
Currently only wired up for Classic folders, awaiting the upcoming NSF folder-move API (#2324) to apply this to NSF.
import --format json