feat(web): smooth first-visit onboarding into shortcut practice - #2907
Merged
Conversation
Add an unnumbered intro before Level 1 so Explore/Escape is an intentional start, style the welcome FAQ shortcuts, jump 6–0 to social and legal links, and drop the legend hint while welcome is open. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
August 27, 2026 16:44
Publish first-visit visibility on the existing welcome guide store, render footer jumps from the guide body, and reuse the showcase signup shortcut on the intro step. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Welcome-started practice now lands on the intro, and the full web suite mocks ShortcutHint without c-keycap. Point the assertions at those. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Keep Close inside WelcomeGuideBody so footer jumps stay after the CTA, and keep the Esc chip from the visible-shortcuts work on main. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First-time Explore / Escape no longer drops people straight into Level 1/6. The showcase now opens on an unnumbered intro that explains Compass is keyboard-only, then Start practicing (Enter) begins the levels. Palette replay still skips the intro.
Welcome FAQ answer for “I don’t know any shortcuts” renders
?and Mod+K as keycaps. The hold hint is nowTip: Hold [Mod] to see keys, then press a number.Digits 6–0 jump to X, LinkedIn, GitHub, Privacy, and Terms on both welcome surfaces. Clicking while welcome is open showsCompass is keyboard only.without advertising?.Simplicity
Folded first-visit visibility into the existing welcome guide store (deleted
welcome.modal.store.ts). Footer jumps now render fromWelcomeGuideBody, so the Mod-hold context is gone. Intro signup reuses the showcase U handler.Merge conflict
Simple, one file:
WelcomeGuideModal.tsx. This branch wraps Close insideWelcomeGuideBodyso footer jumps stay after the CTA. Main added a visible Esc chip on Close. Kept both: Close remains aWelcomeGuideBodychild and still shows the Esc keycap.Automated validation
7179d4eb2was green (21/21); re-running after merging mainIndependent review
Not run.
Test plan