fix: resolve 5 type/safety bugs across adapters, jsx, data, and widgets#3075
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix: resolve 5 type/safety bugs across adapters, jsx, data, and widgets#3075tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
- fix(adapters): fix ConfStore.config type to use ConfInstance<T> instead of { store: T }
- fix(jsx): use useLayoutEffect in usePrevious so ref updates synchronously (closes Karanjot786#3073)
- fix(data): add loadingRef to useInfiniteQuery fetchNextPage deps array (closes Karanjot786#3072)
- fix(widgets): remove redundant clamp01 call in ProgressCircle.setValue (closes Karanjot786#3070)
- fix(jsx): fix useThrottle stale intervalRef capture in runTimeout (closes Karanjot786#3071)
Closes Karanjot786#3074
Closes Karanjot786#3073
Closes Karanjot786#3072
Closes Karanjot786#3070
Closes Karanjot786#3071
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates configuration adapter typing, React hook lifecycle and dependency handling, throttle interval scheduling, previous-value tests, and progress value assignment. ChangesConfiguration, hooks, and widgets
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 5 bugs across 4 packages:
adapters/confConfStore.configtyped asConfInstance<T>instead of{ store: T }jsxusePrevioususesuseLayoutEffectso ref updates synchronouslydataloadingRefadded touseInfiniteQueryfetchNextPagedepswidgetsclamp01(value)call inProgressCircle.setValuejsxuseThrottlerunTimeoutusesintervalRef.currentinstead of stale closureCI
All checks pass:
bun run build✅bun vitest run✅ (427 files, 5976 tests)bun run typecheck✅Closes #3074
Closes #3073
Closes #3072
Closes #3070
Closes #3071
Summary by CodeRabbit
Bug Fixes
Internal Improvements