docs(wallet): document multi-wallet flow, remove dead FreighterAdapter - #82
Open
jerrymusaga wants to merge 1 commit into
Open
docs(wallet): document multi-wallet flow, remove dead FreighterAdapter#82jerrymusaga wants to merge 1 commit into
jerrymusaga wants to merge 1 commit into
Conversation
…pter xBull (and Lobstr/Hana/Rabet) desktop support already works end-to-end via Stellar Wallets Kit — no per-provider code was missing. This just removes the unused back-compat FreighterAdapter (superseded by StellarWalletAdapter) and documents the current provider-agnostic connect/sign flow, including xBull's desktop behavior. Closes Kalebtron1#74
|
@jerrymusaga is attempting to deploy a commit to the alankcr1-6443's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@jerrymusaga Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #74 asked for xBull wallet support on desktop. Investigation found that xBull (along with Lobstr, Hana, Rabet) is already fully supported end-to-end via Stellar Wallets Kit (
src/lib/stellarWalletsKit.ts), which has been the connect/sign backbone since an earlier migration off the direct Freighter/Albedo integration referenced in the issue's original file list. There was no missing per-provider connection or signing logic to add.What this PR does instead:
src/wallet/FreighterAdapter.tsand its re-export insrc/wallet/index.ts— dead code kept "for back-compat" with no real consumers; the app usesStellarWalletAdapter, which delegates everything to the kit.docs/architecture.mddocumenting the current provider-agnostic connect/sign flow and xBull's desktop behavior specifically.Before / after
Before:
src/wallet/still exposed a single-providerFreighterAdapter(unused) alongside the realStellarWalletAdapter;docs/architecture.mddescribed auth as "Freighter/Albedo" only, with no mention of xBull, Lobstr, Hana, or Rabet, and no explanation of how a new provider is added.After:
src/wallet/only exposes the adapter that's actually used.docs/architecture.mddocuments that connect/sign go through Stellar Wallets Kit's own modal, lists all six registered wallet modules, and explains that adding a new provider only requires registering its module instellarWalletsKit.ts. Existing desktop (Freighter, xBull, Lobstr, Hana, Rabet) and mobile (Albedo) behavior is unchanged — this is a doc + dead-code cleanup, not a behavior change.What's supported / not supported (per issue's acceptance criteria)
stellarWalletsKit.ts(xBullModule) prior to this change.Test plan
tsc --noEmitpasses clean after removingFreighterAdapter.tsFreighterAdapterinsrc/Closes #74