Skip to content

Optimize and rewrite texture loading #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Phantomical wants to merge 15 commits into
base: dev
Choose a base branch
from
+1,049 −773
Draft

Optimize and rewrite texture loading #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
82fb55b
Initial texture loading overhaul prototype
Phantomical Apr 29, 2026
961e5fa
Avoid initializing texture pixels when creating them
Phantomical Apr 29, 2026
a22bc99
Add some yields to avoid UnshareTextureData overhead
Phantomical Apr 29, 2026
9f436f0
Add some more tracing spans
Phantomical Apr 30, 2026
5e7e396
Clean up some messy code
Phantomical Apr 30, 2026
bf639ef
Simplify a comment
Phantomical Apr 30, 2026
6f35b32
Allow NPOT dds textures to have mipmaps
Phantomical Apr 30, 2026
bfe11aa
Cleanup cached PNG path
Phantomical Apr 30, 2026
8ab1d5d
Avoid allocating secondary textures for swizzles
Phantomical Apr 30, 2026
126ab2b
Actually compress TGA images
Phantomical Apr 30, 2026
c24c9c0
Fix a double-count in loaded textures
Phantomical Apr 30, 2026
a6f11a2
Fix an OOB write in the TGA loader
Phantomical Apr 30, 2026
03b3e60
Delay Load Texture log until the texture load has actually completed
Phantomical May 2, 2026
ddec969
Properly delay until render thread is finished
Phantomical May 2, 2026
40de810
Move completed texture loading after dispatches
Phantomical May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion KSPCommunityFixes/GlobalSuppressions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@
[assembly: SuppressMessage("Style", "IDE0017:Simplify object initialization")]
[assembly: SuppressMessage("Design", "CA1031:Do not catch general exception types")]
[assembly: SuppressMessage("Style", "IDE0016:Use 'throw' expression", Justification = "<Pending>", Scope = "member", Target = "~M:KSPCommunityFixes.BasePatch.PatchInfo.#ctor(KSPCommunityFixes.BasePatch.PatchMethodType,System.Reflection.MethodBase,KSPCommunityFixes.BasePatch,System.String,System.Int32)")]
[assembly: SuppressMessage("Design", "CA1034:Nested types should not be visible", Justification = "<Pending>", Scope = "type", Target = "~T:KSPCommunityFixes.TextureLoaderOptimizations.CachedTextureInfo")]
[assembly: SuppressMessage("Style", "IDE0028:Simplify collection initialization", Justification = "<Pending>", Scope = "member", Target = "~M:KSPCommunityFixes.LocalizationUtils.GenerateLocTemplate(System.String)")]

18 changes: 0 additions & 18 deletions KSPCommunityFixes/Internal/PatchSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ protected override void ApplyPatches()
if (disableMHPatch != null)
entryCount++;

if (KSPCFFastLoader.IsPatchEnabled)
entryCount++;

// NoIVA is always enabled
entryCount++;
}
Expand Down Expand Up @@ -107,21 +104,6 @@ static void GameplaySettingsScreen_DrawMiniSettings_Postfix(ref DialogGUIBase[]
count++;
}

if (KSPCFFastLoader.IsPatchEnabled)
{
DialogGUIToggle toggle = new DialogGUIToggle(KSPCFFastLoader.TextureCacheEnabled,
() => (KSPCFFastLoader.TextureCacheEnabled)
? Localizer.Format("#autoLOC_900889") //"Enabled"
: Localizer.Format("#autoLOC_900890"), //"Disabled"
KSPCFFastLoader.OnToggleCacheFromSettings, 150f);
toggle.tooltipText = KSPCFFastLoader.LOC_SettingsTooltip;

modifiedResult[count] = new DialogGUIHorizontalLayout(TextAnchor.MiddleLeft,
new DialogGUILabel(() => KSPCFFastLoader.LOC_SettingsTitle, 150f),
toggle, new DialogGUIFlexibleSpace());
count++;
}

DialogGUISlider noIVAslider = new DialogGUISlider(NoIVA.PatchStateToFloat, 0f, 2f, true, 100f, 20f, NoIVA.SwitchPatchState);
noIVAslider.tooltipText = NoIVA.LOC_SettingsTooltip;
DialogGUILabel valueLabel = new DialogGUILabel(NoIVA.PatchStateTitle);
Expand Down
2 changes: 2 additions & 0 deletions KSPCommunityFixes/KSPCommunityFixes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@
<Publicize Include="UnityEngine.CoreModule:UnityEngine.Object.GetOffsetOfInstanceIDInCPlusPlusObject" />
<Publicize Include="UnityEngine.IMGUIModule" />
<Publicize Include="UnityEngine.CoreModule:Unity.Collections.NativeArray`1.m_Buffer" />
<Publicize Include="UnityEngine.CoreModule:UnityEngine.Texture2D.Internal_Create" />
<Publicize Include="UnityEngine.CoreModule:UnityEngine.Texture.ValidateFormat" />
<Publicize Include="mscorlib:System.Runtime.CompilerServices.Unsafe" />
<Publicize Include="mscorlib:System.IO.MonoIO" />
<Publicize Include="mscorlib:System.IO.MonoIOError" />
Expand Down
Loading