You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @KENZY004! 👋 #211
I've fixed this issue. Here's what I did:
Changes Made:
server/services/emailService.js
Added a graceful fallback at the start of sendRegistrationVerificationEmail() — when SMTP_USER and RESEND_API_KEY both are missing, instead of failing and deleting the user, it now:
Logs the OTP to the server console in dev mode
Returns { success: true } so registration completes normally
server/.env.example
Added all required email environment variables with clear comments so contributors know exactly what to configure.
Testing Done:
✅ Signup with no email credentials configured → OTP printed in server terminal → Verification page loads → Account activated successfully
✅ No user deletion on missing email config
✅ .env.example documents all required variables clearly
Before this fix: Registration failed with "Failed to send verification email" and user was deleted.
After this fix: In dev mode, OTP is logged to console and registration completes successfully. In production with proper credentials, normal email flow works as before.
Hey @aarushii25, thanks for the detailed PR description and the testing screenshots! The fallback feature looks exactly like what we need.
However, there are a couple of issues we need to address before this can be merged:
🔴 Missing Files in the PR It looks like the backend changes are missing from the PR. The files server/services/emailService.js and server/.env.example that you listed under "Changes Made" are not included in the commits pushed to this branch. Please make sure to track, commit, and push these files so we can review them!
🔴 Clean up debug comments There are some inline comments in Hindi left in the client code (e.g., in App.jsx and FAQPage.jsx):
Please remove these comments before we merge.
Once you push the missing backend files and clean up the comments, I'll be happy to review it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @KENZY004! 👋
#211
I've fixed this issue. Here's what I did:
Changes Made:
Added a graceful fallback at the start of sendRegistrationVerificationEmail() — when SMTP_USER and RESEND_API_KEY both are missing, instead of failing and deleting the user, it now:
Logs the OTP to the server console in dev mode
Returns { success: true } so registration completes normally
Added all required email environment variables with clear comments so contributors know exactly what to configure.
Testing Done:
✅ Signup with no email credentials configured → OTP printed in server terminal → Verification page loads → Account activated successfully
✅ No user deletion on missing email config
✅ .env.example documents all required variables clearly
Before this fix: Registration failed with "Failed to send verification email" and user was deleted.
After this fix: In dev mode, OTP is logged to console and registration completes successfully. In production with proper credentials, normal email flow works as before.
Ready for review!


