Use stdlib toHexString#1242
Open
twyatt wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6bfa4b5. Configure here.
Member
Author
|
Ran Results |
twyatt
marked this pull request as ready for review
July 23, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
ManufacturerDataandServiceDatatoStringoutputs will now have lowercase hex (previously was uppercase).This is more aligned with the default
toHexStringformat provided by the stdlib, but should be called out in the release notes when this ships.Note
Low Risk
Display/logging-only refactor with no BLE filtering or I/O behavior changes; minor
toString()formatting differences possible where default hex casing differs from the old helper.Overview
Replaces the internal Tuulbox-style
ByteArray.toHexStringhelper with Kotlin stdlibtoHexString/HexFormat.Logging hex output (
logs/Hex.kt) now builds aHexFormatfrom existingHexBuilderoptions (byte separator and upper vs lower case) and passes it todata.toHexString(format).Filter debug strings for
ManufacturerDatauseHexFormat.UpperCasefordataso those fields stay uppercase intoString();dataMaskuses the default format.Reviewed by Cursor Bugbot for commit 6bfa4b5. Configure here.