Repository navigation
FE-Admin-Shell - #58
Merged
Merged
Conversation
Sign in successful redirected to Applicants page with other placeholder pages.
…-place into FE-admin-shell
Adding the profile section later makes the tabs section go to the middle, for now since we don't know the dimensions of those everything works fine. Added redirect to the AdminDashboardPage. Made Admin Tabs a little faster by doing a const of the isActiveTab. Also ran Prettier on everything.
Slightly better but have to get design insights from the bosses.
natphua
approved these changes
Nov 11, 2026
natphua
left a comment
natphua
left a comment
Collaborator
There was a problem hiding this comment.
Amazing work guys! Thanks for being thorough about the tabs and layout.tsx stuff, I know it can get confusing sometimes. Everything looks great, and keep up the good work 😁
| { label: "Edits", href: "/admin/edits" }, | ||
| ]; | ||
|
|
||
| // TODO: function contract |
Collaborator
There was a problem hiding this comment.
You forgot function contract and file header here 😔
Small so I will add it in myself but look over everything next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Me and @cartier37 worked on making the admin tabs for the admin profile view.
isActiveTab makes sure every tab click stays on the selected tab even on reload.
Every tab has a page related to it but just placeholders for now.
The tabs will naturally move down to the center when profile section is added but for now functionality is completely there.
On phone only the AdminTab bar moves left and right.
Related Issue
Closes #42
Files Changed:
Files Added:
admin-tabs.ts: Admin Tabs listadmin-tabs.test.ts: Jest tests for admin-tabs/(dashboard)/applicants/page.tsx: CallsrequireAdminPage()and shows a heading and "Coming soon."/(dashboard)/volunteers/page.tsx: CallsrequireAdminPage()and shows a heading and "Coming soon."/(dashboard)/edits/page.tsx: CallsrequireAdminPage()and shows a heading and "Coming soon."/(dashboard)/scheduling/page.tsx: CallsrequireAdminPage()and shows a heading and "Coming soon."How to test
npm run dev
Screenshots
Notes
The top bar's "Damien's Food Pantry" text wraps onto two lines on phones. That comes from the protected layout, which this ticket doesn't change.
Estimated Hours Spent
4.67
Checklist before requesting a review