Repository navigation
Fe save resume - #56
Conversation
natphua
left a comment
natphua
left a comment
There was a problem hiding this comment.
Overall, amazing work guys! Thank you for the detailed PR - it really shows you did a lot of testing and were thorough with your work. There were a few nitpicks about style (comments having DONE, or forgetting to update file headers), but in general it looks great. Just keep in mind my feedback for future ticket implementations
| }); | ||
| }); | ||
|
|
||
| // Lusia and Rim addition |
There was a problem hiding this comment.
If you update a file, usually your names + edited date should go in the file header
| // DONE: in goNext, saveDraftId right after createApplicant succeeds | ||
| // TODO: while `resuming`, show only "Loading your saved application...". If `resumeError`, show it with two | ||
| // CommonButtons: "Try again" and "Start a new application" (altStyle). Otherwise the form, as it is today. | ||
|
|
There was a problem hiding this comment.
Instead of leaving // DONE: ...., either remove the comment or remove any DONE/TODO heading. I know you probably had it while you were working (which was good), but before you make a PR, do a pass to ensure no headings are added and comments are consistent.
| /** | ||
| * draft-storage.ts | ||
| * | ||
| * <1-3 sentences: what this file does and why it exists.> |
There was a problem hiding this comment.
Missed file header description here 😢
Describe your changes
Worked with @RimBadaoui and
Related Issue
Closes #44
Files changed
How to test
Run npx jest src/components/application/application-state.test.ts src/lib/draft-storage.test.ts.
Open /apply, complete Step 1, and click Next. Check the draft ID is saved in localStorage.
Refresh and check the application resumes at the first incomplete step, with previous answers restored.
Click Back to verify the saved Personal Information fields are there.
Change the saved draft ID to nope, refresh, and check that the application starts fresh.
Select network error and verify the Try again and Start a new application buttons work.
Screenshots
Estimated Hours Spent
3.5
Checklist before requesting a review