Repository navigation
completed ticket for applicant approve/reject - #49
Merged
Merged
Conversation
natphua
approved these changes
Nov 9, 2026
natphua
left a comment
natphua
left a comment
Collaborator
There was a problem hiding this comment.
Amazing work guys! It looks great. Though, there are a few things:
- Make sure your PR contains screenshots, how to test, etc. (aka fill in everything loaded from the PR template when you make a PR!). This tells us that you tested all the cases and have evidence to show for it. Also the estimated hours worked helps us gauge ticket difficulty
- Not sure if this wasn't clear enough in the ticket, but we want the decision controls to look like the Figma (long buttons, green/red states after approving/rejecting). For the CommonButton, you can simply pass in
fullWidth: trueto get the button to cover the entire container (like the Figma). Since you guys will be adding these controls into the details page in the next sprint, you might have to do slightly more frontend work there
Let me know if you have any questions! Keep up the great work
| /** | ||
| * ApplicantDecisionControls /src/components/admin/ | ||
| * | ||
| * Admin can approve/reject submitted applicants. Display confirm modal while updating applicant status. * |
Collaborator
There was a problem hiding this comment.
Remove weird characters like these ( *) before making a PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
me and @alexli24 did the API approve/reject. As well as the button for applicant to be approved/rejected.
Related Issue
Closes #43
Files changed
src/app/decision-controls-test/: testing our buttons
src/components/admin/ApplicantDecisionControls.tsx: approve/reject buttons
src/lib/admin-api.test.ts: test admin-api
src/lib/admin-api.ts: admin approve/reject
How to test