Repository navigation
Fe application wiring - #48
Merged
Merged
Conversation
Created application-api with unique return types for createApplicant and updateApplicant. Added body === null check for further hardening. Started changes for ApplicationFormShell
Application Form Shell has correct functionality from no throttling and setting Network to 3G, where after submitting a POST request to create an applicant, no other changes made will do a POST but rather PATCH and update the info. Steps 4 and 5 greyed out still. Updated application-api with hardening and corrections for patching based on the user's id.
Updated proxy.ts to be updated for the proof of residence url.
natphua
marked this pull request as ready for review
November 4, 2026 21:02
natphua
approved these changes
Nov 4, 2026
natphua
left a comment
natphua
left a comment
Collaborator
There was a problem hiding this comment.
Great job guys!
Nice work on being thorough with your testing, especially since this ticket requires piecing a lot of components together. Your code is also clean and easy to read 😁
Congrats on finishing this sprint and keep up the good work 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
@Echandler123 and I worked on connecting Steps 1 - 3 to the Application Form Shell that was an earlier ticket. After the personal info step, no other usage of the NEXT button makes a POST request (for now obviously since no Step 4 and 5) and only PATCHES that user's created id. With this we created API functionality to help with creating an applicant and updating their info as well as having a payload for each of the first 3 steps of the application.
Related Issue
Closes #32
Files Added:
application-state.ts: Tests the application form state and API payload functions.application-state.test.ts: Defines the application form state and builds payloads for saving applicant information to the backend.application-api.ts: API functions for the volunteer application form.Files Changed:
ApplicationFormShell.tsx: Added Steps 1 - 3 into the main application shell that saves a created user's draft version of the volunteering application.proxy.ts: Needed to make functionality to connect fully from the newly created routes to the proof of residence urlHow to test
Open npm run dev THEN in a separate terminal run "npx prisma studio"
Go to /apply and fill in personal identifying info
After pressing Next fill out steps 2 and 3
The cool part is now testing that once you back and forth you should have saved values
Throughout all of these steps keep check of the Applicant table to make sure DRAFT is consistent of any entries you create as well as that info is being parsed correctly, proofOfResidence is a URL or file, that every PATCH request is complete and that on reloading the prisma studio the info is updated for the applicant.
Screenshots
Estimated Hours Spent
5
Checklist before requesting a review