Skip to content

FE: Step 5 review page - #47

Merged
natphua merged 3 commits into
mainfrom
FE-review-step
Nov 4, 2026
Merged

natphua merged 3 commits into
mainfrom
FE-review-step

Conversation

@adrientab

Copy link
Copy Markdown
Collaborator
Screenshot 2026-11-03 at 11 41 06 PM Screenshot 2026-11-03 at 11 41 11 PM Screenshot 2026-11-03 at 11 41 25 PM Screenshot 2026-11-03 at 11 41 35 PM

@adrientab
adrientab requested a review from natphua November 4, 2026 04:50

@natphua natphua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great guys!

Two things though:

  1. I noticed the page is slightly different from the Figma. Generally we want the Figma to be the source of truth, since that is what the client approved and what we go by. I will approve for now since you guys already wrapped the ticket up, but next time if you think a change in design would be simpler to implement (or more intuitive), start a chat with me/Begum/Olivia so that we can give u the green light
  2. Make sure your PRs follow the structure of the template!!! That means description, partner tagged, closes a linked issue number, etc. You can check out other PRs for examples

Otherwise, keep up the good work 😁

@natphua
natphua merged commit d8d3ee3 into main Nov 4, 2026
2 checks passed
@natphua
natphua deleted the FE-review-step branch November 4, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants