Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces new path-finding APIs (getPath / getPaths) for navigating factor graphs, refactors older path-related helpers toward those APIs, and adds test coverage for common pathfinding scenarios and filter combinations.
Changes:
- Add
getPaths/getPathto the AbstractDFG API surface (as declared services) and implement them using Graphs.jl algorithms in the GraphsDFG backend. - Deprecate/redirect legacy path utilities (
findShortestPathDijkstra,findFactorsBetweenNaive) toward the new APIs. - Add a dedicated “Path Finding” testset covering shortest path, k-shortest paths, and filtering behavior (labels/solvable/tags).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/services/AbstractDFG.jl |
Declares getPaths / getPath services; adjusts subgraph convenience wrapper naming. |
src/GraphsDFG/services/GraphsDFG.jl |
Implements getPaths (A*, Yen) and getPath, plus subgraph restriction support. |
src/GraphsDFG/GraphsDFG.jl |
Imports the new path APIs for extension within the GraphsDFG module. |
src/DistributedFactorGraphs.jl |
Marks getPath / getPaths as unstable API functions. |
src/Deprecated.jl |
Refactors legacy path utilities to deprecate/redirect to getPath[s]. |
test/testBlocks.jl |
Adds PathFindingTests covering multiple graph/path/filter scenarios. |
test/interfaceTests.jl |
Adds a "Path Finding" testset invoking PathFindingTests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1214 +/- ##
===========================================
+ Coverage 79.16% 79.96% +0.79%
===========================================
Files 37 37
Lines 2506 2520 +14
===========================================
+ Hits 1984 2015 +31
+ Misses 522 505 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y still wrong verbNoun)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.