Conversation
Affie
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and extends blob support by introducing MIME↔FileIO format bridging for blob packing/unpacking, adding factor-level blob wrapper APIs, and aligning Summary-level graph nodes with the solvable flag while removing blobentries from VariableSummary.
Changes:
- Add MIME/type bridging utilities (
format_to_mime,mime_to_format,getMimetype) and corresponding tests for blob packing/unpacking. - Introduce factor-level blob CRUD wrappers (
loadBlob_Factor,saveBlob_Factor!,deleteBlob_Factor!) and add coverage for LinkStore/RowBlobstore and wrapper behaviors. - Update Summary/skeleton comparisons and patching to handle
solvableas aRefValue, and removeblobentriesfromVariableSummary(with tests adjusted accordingly).
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testSerializingVariables.jl | Adjusts VariableSummary serialization expectations after removing blobentries. |
| test/testBlocks.jl | Updates summary-graph equality checks to unwrap solvable refs. |
| test/testBlobStoresAndWrappers.jl | Adds new tests for LinkStore/RowBlobstore and blob wrapper APIs. |
| test/testBlobPacking.jl | Adds new tests for MIME/format mapping and pack/unpack behavior. |
| test/runtests.jl | Registers the new blob-related test files in the test runner. |
| test/iifInterfaceTests.jl | Updates Summary comparisons to handle solvable as a RefValue. |
| src/services/find.jl | Removes deprecated path helper implementations from the main services file. |
| src/services/CompareUtils.jl | Generalizes equality for graph variables/factors and removes Summary types from generated-compare union. |
| src/services/AbstractDFG.jl | Removes deprecated isPathFactorsHomogeneous from this file (moved to Deprecated). |
| src/entities/DFGVariable.jl | Updates VariableSummary fields (adds solvable, removes blobentries) and adjusts patch/constructors. |
| src/entities/DFGFactor.jl | Adds solvable handling to FactorSummary and its constructors/patching. |
| src/DistributedFactorGraphs.jl | Adds MIMEs dependency and marks blob/MIME helpers and Summary types as “unstable”. |
| src/Deprecated.jl | Relocates legacy path helpers into the Deprecated module area. |
| src/DataBlobs/services/BlobWrappers.jl | Adds factor blob wrapper API and switches image save path to mime_to_format. |
| src/DataBlobs/services/BlobPacking.jl | Implements MIME↔DataFormat bridge + getMimetype, refactors pack/unpack around MIME metadata. |
| ext/BlobArrow.jl | Updates Arrow extension to register its MIME mapping via _MIMEOverrides. |
| Project.toml | Adds MIMEs dependency and compat entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1213 +/- ##
===========================================
+ Coverage 75.01% 79.16% +4.15%
===========================================
Files 37 37
Lines 2465 2506 +41
===========================================
+ Hits 1849 1984 +135
+ Misses 616 522 -94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.