You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes indeed, that's the idea, true is equal to 1 and sits the lowest in the promotion hierarchy for Real numbers. If this is not desired, perhaps one may define an analogous real identity type that isn't a Bool but gets promoted identically.
Where would this approach leave e.g. sqrt4π * invsqrt2π? Is there a more general approach that covers that and similar cases? Would handling those relations be worth the overhead [i.e. what would be a parsimonious and effective way to handle exact integer ratios and their reciprocal results]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that many of the constants defined here are reciprocals of each other, we may specialize
invandliteral_powto improve floating-point accuracy.On main
This PR