Adds support for specifying kernels using StaticArrays#254
Open
zygmuntszpak wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
===========================================
+ Coverage 78.62% 91.97% +13.34%
===========================================
Files 12 12
Lines 1062 1657 +595
===========================================
+ Hits 835 1524 +689
+ Misses 227 133 -94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@timholy Please could you take a look when you get a chance |
mkitti
reviewed
Dec 31, 2022
Member
|
Sorry I missed this PR and the issue. Will check it ASAP. |
| hi = last(ind)+last(pad) | ||
| interval = 1:length(lo:hi) | ||
| T = typeof(T₁) | ||
| I = typeof(SOneTo(length(interval))) |
Member
There was a problem hiding this comment.
This is unfortunately a type-unstable patch: SOneTo{n} where n = length(interval) is runtime information.
IIUC, unless the image itself is also a SMatrix, we can't get a static pad, and thus we can't make it type stable.
The solution to support static array inputs might be converting it back to normal array and unit ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252