handle missing vendor info in OpenCL version string gracefully#457
Merged
Conversation
On my laptop, XRT advertises the NPU via OpenCL, but the version returned by the query is just `"OpenCL 1.0"` without any vendor info. Handle that case gracefully so at least `OpenCL.versioninfo()` doesn't error
Member
|
Can you rebase? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 13 13
Lines 914 914
=======================================
Hits 739 739
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
https://github.com/JuliaGPU/OpenCL.jl/actions/runs/29565903596/job/87838349478?pr=457 seems real but unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my laptop, XRT advertises the NPU via OpenCL, but the version returned by the query is just
"OpenCL 1.0"without any vendor info. Handle that case gracefully so at leastOpenCL.versioninfo()doesn't error