Dynamic threadgroup memory#750
Draft
christiangnrd wants to merge 9 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 78.55% 82.03% +3.47%
==========================================
Files 67 64 -3
Lines 3605 3590 -15
==========================================
+ Hits 2832 2945 +113
+ Misses 773 645 -128 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
26d4370 to
70d9023
Compare
0b9c156 to
c6bf0b4
Compare
[only tests] [only special]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly it's somewhat functional. Only macOS 15+ since the global dynamic threadgroup memory is not available before then. This isn't the only way to get this dynamic threadgroup memory, but I tried this approach as my first attempt since it seemed the most similar to how static threadgroup memory is implemented.
The Metal interface takes an Integer or a Tuple of the size of the allocation, which is then aligned to the next multiple of 16.
Kernels silently fail under shader validation (which are caught in the tests since the output doesn't match expected results.
TODO:
Close #701