Skip to content

MPS solve#145

Closed
tgymnich wants to merge 4 commits into
JuliaGPU:mainfrom
tgymnich:mps-solve
Closed

MPS solve#145
tgymnich wants to merge 4 commits into
JuliaGPU:mainfrom
tgymnich:mps-solve

Conversation

@tgymnich

@tgymnich tgymnich commented Mar 22, 2023 •
edited by christiangnrd
Loading

Copy link
Copy Markdown
Member

Closes #402

@tgymnich

tgymnich commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I seem to be getting blocks of NaNs when solving systems larger than 128x128. Weird....

@tgymnich tgymnich force-pushed the mps-solve branch 3 times, most recently from 5ab3330 to 80af119 Compare March 31, 2023 19:12
@maleadt maleadt added libraries Things about libraries and how we use them. arrays Things about the array abstraction. enhancement labels May 22, 2023
@tgymnich tgymnich force-pushed the mps-solve branch 2 times, most recently from c8d4a9e to af07cd6 Compare September 5, 2023 14:05
@tgymnich tgymnich mentioned this pull request Apr 10, 2024
Closed
@jpsamaroo

jpsamaroo commented Jul 2, 2024

Copy link
Copy Markdown
Member

@tgymnich did you ever resolve the NaN issue? @Rabab53 has also been encountering these while trying to use the MPS triangular solve.

@tgymnich

tgymnich commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@jpsamaroo I have looked into it recently and the error still seems to be present.

@tgymnich tgymnich mentioned this pull request Jul 5, 2024
Open
@tgymnich tgymnich mentioned this pull request Jul 27, 2024
Closed
@maleadt maleadt force-pushed the main branch 2 times, most recently from 5a8daaa to b9610e3 Compare December 19, 2024 08:12
@christiangnrd

christiangnrd commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Same problems, new base :)

BTW, these tests also fail for CPU Arrays.

@christiangnrd christiangnrd mentioned this pull request Aug 19, 2025
Open
@christiangnrd christiangnrd mentioned this pull request Jun 22, 2026
Merged
@maleadt

maleadt commented Jun 22, 2026

Copy link
Copy Markdown
Member

Superseded by #853. I couldn't reproduce the NaN issue in here, but will add a test covering it.

@maleadt maleadt closed this Jun 22, 2026
@maleadt maleadt mentioned this pull request Jun 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arrays Things about the array abstraction. blocked libraries Things about libraries and how we use them.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement MPSMatrixSolve

4 participants

@tgymnich @jpsamaroo @christiangnrd @maleadt