Extend CUDACore.jl instead of CUDA.jl - #82
Open
christiangnrd wants to merge 7 commits into
Open
christiangnrd wants to merge 7 commits into
christiangnrd wants to merge 7 commits into
Conversation
Contributor
Author
|
If we REALLY want to keep supporting CUDA 5, I think there's a potentially hacky way to do it with a dummy extension but I think it should be avoided unless we have a concrete example of a user with a good reason to still be on CUDA 5 that needs this functionality |
Member
|
Let's make this 1.3? |
christiangnrd
force-pushed
the
cudacore
branch
from
September 8, 2026 20:01
e6bb79d to
6b9fea2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
===========================================
- Coverage 92.95% 56.57% -36.39%
===========================================
Files 6 10 +4
Lines 142 251 +109
===========================================
+ Hits 132 142 +10
- Misses 10 109 +99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vchuravy
reviewed
Sep 9, 2026
Contributor
Author
|
Can we merge #77 first so that buildkite tests also run on 1.12? |
vchuravy
approved these changes
Sep 9, 2026
Contributor
Author
|
Bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This'll cause a lot of confusion from people not using all of CUDA.jl if not fixed.
I also think that either 1.2.0 should get yanked or this be released in 1.2.2 seperate from #81 so that users still on CUDA 5.x don't end up with 1.2.0
@vchuravy
Closes #74