Skip to content

Conversation

@Roger-luo
Copy link
Collaborator

fix #8

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #9 (30b3400) into master (2169e5f) will decrease coverage by 0.50%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   85.35%   84.86%   -0.50%     
==========================================
  Files           9        9              
  Lines         519      522       +3     
==========================================
  Hits          443      443              
- Misses         76       79       +3     
Impacted Files Coverage Δ
src/patches.jl 70.45% <50.00%> (ø)
src/passes.jl 80.98% <66.66%> (-0.45%) ⬇️
src/typeinf.jl 83.33% <75.00%> (-16.67%) ⬇️

... and 1 file with indirect coverage changes

@willtebbutt
Copy link

@Roger-luo are you interetsed in re-visiting this PR now that 1.9 has stabilised?

@Roger-luo Roger-luo closed this May 15, 2023
@Roger-luo Roger-luo reopened this May 15, 2023
@Roger-luo
Copy link
Collaborator Author

I can take a look but no promise - it depends on how complicated it is to figure out a fix. But I think given how much internal has changed it probably makes more sense to rewrite this package instead of maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not load symbol "jl_typeinf_begin" on nightly

3 participants