Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 93.81% 93.86% +0.05%
==========================================
Files 28 27 -1
Lines 1844 1843 -1
==========================================
Hits 1730 1730
+ Misses 114 113 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Both are breaking changes.
It is possible to use the × operator (\times) both in v0.7.17 and in v0.8, but they are different functions. In v0.7 it is the same as LinearAlgebra.cross, in v0.8 it is not. Any dependent package should remain compatible with both versions as long as DomainSets.× and LinearAlgebra.× are not mixed (which, logically, they shouldn't).
Most of the exports of DomainSets are now in the union of the exports of DomainSets and FunctionMaps. Thus, it should suffice to replace "using DomainSets" by "using DomainSets, FunctionMaps". A small number of exports of internal functions were removed. They can be qualified using DomainSets or FunctionMaps. They include:
"CartToPolarMap"
"ComposedMap"
"PolarToCartMap"
"StaticIdentityMap" (use IdentityMap instead)
"TypedMap"
"VectorIdentityMap" (use IdentityMap instead)
"rotation_map"