Remove internal copy of FunctionMaps in favour of FunctionMaps.jl package#177
Merged
Remove internal copy of FunctionMaps in favour of FunctionMaps.jl package#177
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 93.91% 93.81% -0.11%
==========================================
Files 27 28 +1
Lines 1842 1844 +2
==========================================
Hits 1730 1730
- Misses 112 114 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daanhb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past year, DomainSets has had an internal copy of FunctionMaps, while the package FunctionMaps.jl also existed. This meant that DomainSets and FunctionMaps could not work together.
This PR is the last step in taking out the functionality of FunctionMaps from DomainSets. It aims to do so in a non-breaking way. All functionality of maps that was exported before is still exported. The only difference in functionality comes from small differences between DomainSets.FunctionMaps and the official FunctionMaps. These were some minor cleanups. Deprecations have been added to DomainSets for the transition.
In the next breaking release of DomainSets, the exported functionality related to maps will be unexported. Packages downstream should replace "using DomainSets" by "using DomainSets, FunctionMaps" if they want to retain that functionality. The goal is that, after this PR, "using DomainSets, FunctionMaps" will work both with DomainSets v0.7.17 and DomainSets v0.8.x. Note that it will not work with earlier versions of the 0.7.x series.
In v0.8 we will also distinguish between DomainSets: × (\times) and LinearAlgebra.cross. A deprecation message to that effect is already added in this PR. In v0.7 \times will be the same as LinearAlgebra.cross, but in v0.8 they will be different. In v0.7.17 and v0.8 alike packages can use the new function cartesianproduct instead.