Skip to content

Add compat for Makie 0.23, 0.24#172

Merged
daanhb merged 1 commit intoJuliaApproximation:masterfrom
jaakkor2:compatsForMakie
Jul 28, 2025
Merged

Add compat for Makie 0.23, 0.24#172
daanhb merged 1 commit intoJuliaApproximation:masterfrom
jaakkor2:compatsForMakie

Conversation

@jaakkor2
Copy link
Copy Markdown
Contributor

Tests pass locally. Without this DomainSets go to v0.7.12.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.91%. Comparing base (793535e) to head (bdd8e76).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          27       27           
  Lines        1842     1842           
=======================================
  Hits         1730     1730           
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jaakkor2
Copy link
Copy Markdown
Contributor Author

Hmm, CI / Julia lts - macOS-latest - x64 failure does not seem to be related to this PR.

rosetta error: Failed to open libRosettaRuntime
 ERROR: LoadError: Failed to precompile Makie [ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a] to "/Users/runner/.julia/compiled/v1.10/Makie/jl_hmwymT".

@daanhb daanhb merged commit b68ee03 into JuliaApproximation:master Jul 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants