fix: annotate generated form fields#1640
Merged
JiHong88 merged 1 commit intoMay 2, 2026
Merged
Conversation
Contributor
Author
|
Small contribution note for maintainers:
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 81.76% 81.79% +0.03%
==========================================
Files 131 131
Lines 21913 21917 +4
Branches 6534 6538 +4
==========================================
+ Hits 17917 17928 +11
+ Misses 3113 3106 -7
Partials 883 883
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Chrome surfaces form warnings when generated editor controls have neither id nor name, or recognized fields miss autocomplete. The added ids avoid changing form submission payloads while silencing those diagnostics.
Test