fix: check title visibility separately for mobile/desktop viewports #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile viewports (≤576px), .conf-title is hidden via CSS and .conf-title-small is displayed instead. Playwright's toBeVisible() only checks the first DOM element when multiple elements match a selector, so we need to check each title class separately and verify that at least one is visible.
JesperDramsch
force-pushed
the
claude/fix-e2e-mobile-test-K4fWG
branch
from
713341c to
7872f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile viewports (≤576px), .conf-title is hidden via CSS and .conf-title-small is displayed instead. Playwright's toBeVisible() only checks the first DOM element when multiple elements match a selector, so we need to check each title class separately and verify that at least one is visible.