Skip to content

Conversation

@heoelri
Copy link
Contributor

@heoelri heoelri commented Nov 3, 2025

Removed redundant netty-transport-native-epoll dependency.

Details
The netty-transport-native-epoll dependency is declared twice in dependencyManagement:

  • Line ~869: Initial declaration with other Netty modules
  • Line ~1435: Redundant declaration immediately after excluding it from curator-client

Changes

  • Removed duplicate netty-transport-native-epoll dependency declaration at line ~1435
  • Kept the primary declaration at line ~869


-----

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there an issue associated with this PR? Is it referenced in the commit message?
- [ ] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written and/or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
- [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: heoelri / name: heoelri (411e3b2)

Removed netty-transport-native-epoll dependency.

Signed-off-by: Heyko Oelrichs <[email protected]>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @heoelri !

@porunov porunov added this to the 1.2.0 milestone Nov 4, 2025
@porunov
Copy link
Member

porunov commented Nov 4, 2025

Merging with CTR

@porunov porunov merged commit 00b3eec into JanusGraph:master Nov 4, 2025
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants