Skip to content

chore: rewrite to use @actions/core#168

Closed
icco wants to merge 6 commits into
JamieMagee:mainfrom
icco:errorlogging
Closed

chore: rewrite to use @actions/core#168
icco wants to merge 6 commits into
JamieMagee:mainfrom
icco:errorlogging

Conversation

@icco

@icco icco commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

This started when I saw a logging bug in 2.1.0, but after some googling, saw that @actions/core v3 seems to do all of the same things that were manually implemented in this repo for logging and output and input. Switched to core where I could.

@JamieMagee

Copy link
Copy Markdown
Owner

What was the logging bug you saw? I'd prefer not to add a dependency on @actions/core if possible.

@icco

icco commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

What was the logging bug you saw? I'd prefer not to add a dependency on @actions/core if possible.

https://github.com/icco/writing/actions/runs/24519648282/job/71673612090#step:2:40

Notice: Current job status: error
Notice: Status polling completed after 8 check(s)
Notice: Archive job completed with status: error
Error: Archive job failed with an error
Notice: Full error details: [object Object]

This may be fixed in 2.2.0 not sure, started on this before you released 2.2.0.

@JamieMagee

Copy link
Copy Markdown
Owner

@icco

icco commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Okee dokee! If you prefer to reimplement instead of github owned lib, totes understand, will close.

@icco icco closed this Apr 17, 2026
@JamieMagee

Copy link
Copy Markdown
Owner

Thank you! I appreciate the work you've done so far, and feel free to open issues if there are any other bugs or feature requests you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants