chore: rewrite to use @actions/core#168
Closed
icco wants to merge 6 commits into
Closed
Conversation
Owner
|
What was the logging bug you saw? I'd prefer not to add a dependency on |
Contributor
Author
https://github.com/icco/writing/actions/runs/24519648282/job/71673612090#step:2:40 This may be fixed in 2.2.0 not sure, started on this before you released 2.2.0. |
Owner
|
This was resolved in a1e68c3#diff-17a3e61d998019fdc9f0427550fcfbf740d68cdb616f83730e27ecd12021199b |
Contributor
Author
|
Okee dokee! If you prefer to reimplement instead of github owned lib, totes understand, will close. |
Owner
|
Thank you! I appreciate the work you've done so far, and feel free to open issues if there are any other bugs or feature requests you have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started when I saw a logging bug in 2.1.0, but after some googling, saw that
@actions/corev3 seems to do all of the same things that were manually implemented in this repo for logging and output and input. Switched to core where I could.