Repository navigation
GeoIP: extract beside the cache so the move never crosses filesystems - #15
Merged
Merged
Conversation
downloadMmdb extracted into os.tmpdir() and renamed the database into the cache. When /tmp is its own filesystem (tmpfs, a container mount) the rename fails with EXDEV and every launch that needs GeoIP fails. The temporary directory now lives in the cache directory itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Tests passedCamoufox
The Playwright suite is upstream playwright-python at the tag above, fetched fresh, with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadMmdbextracted the GeoIP archive intoos.tmpdir()and thenrenameSync'd the database into~/.cache/camoufox/geoip/mmdb/. When/tmpis a separate filesystem (tmpfs, a container mount), that rename fails:and every launch that resolves GeoIP fails before the browser starts. The temporary directory is now created inside the cache directory, so the move is a same-filesystem rename. The Python launcher uses
shutil.move, which already handles this.Regression test in
tests/geoip-config.test.tsfails before (extract went to/tmp) and passes after; full TS suite 821 passed, biome and tsc clean.🤖 Generated with Claude Code