Repository navigation
Conversation
…via mkdtemp The fpgen model was staged in tempfile.mkdtemp() and os.replace'd into fpgen's data directory, and an extracted GeoIP database was unpacked in tempfile.TemporaryDirectory() and shutil.move'd into the cache. Since Python 3.13, mkdtemp() on Windows creates an owner-only directory, and a file moved out of it on the same volume keeps that ACL. So a model or database installed from an elevated shell (or over SSH, which is elevated) could not be read by the same user unelevated, or by any other account: the launch failed with "fpgen's model directory is not writable by this user", though the failure was a read. Found on Windows 11 with camoufox 0.5.7b5 under Python 3.14. Add pkgman.write_atomic(): write a temporary file beside the destination, so it takes the directory's permissions, then os.replace it into place. The model's members are all verified before any is written, as before. The permission error now names the file and says how to recover from a model another account installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Tests passedCamoufox
The Playwright suite is upstream playwright-python at the tag above, fetched fresh, with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI run before the upstream PR. Windows + Python 3.13+: model/GeoIP files installed by one account or elevation level are unreadable by another.
🤖 Generated with Claude Code