refactor: signup 페이지 책임 분리 및 구조 단순화#78
Merged
Merged
Conversation
MintPansy
reviewed
May 10, 2026
MintPansy
reviewed
May 10, 2026
MintPansy
reviewed
May 10, 2026
Contributor
MintPansy
left a comment
There was a problem hiding this comment.
고생하셨습니다! 파일 내 코멘트 몇 가지만 확인 부탁드려요!
MintPansy
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 개요
signup페이지 내에서 여러 상태를 하나의 페이지에서 관리하고 있는데, 페이지를 세분화하여 UI와 비즈니스 로직에 맞게 각 역할들을 나누어 책임을 분리했습니다.변경사항 핵심 내용
signup-formform 데이터를 다루는 UI 컴포넌트signup-agreement약관 동의만을 책임지는 UI 컴포넌트use-signup-form회원가입과 관련된 비즈니스 로직 hook🔗 관련 이슈
🛠️ 변경 사항 (Checklist)
✅ 아래 내용을 한 번 더 점검해 주세요
1. 의도와 가독성 (Naming & Readability)
2. 타입과 논리 (Type Safety & Logic)
any사용을 지양하고, 모든 함수의 반환 타입을 명시했나요?null/undefined), 에러가 발생할 경우를 처리했나요?3. 코드 다이어트 (Clean-up)
console.log나 사용하지 않는import를 모두 지웠나요?4. 지속 가능성 (Sustainability)
README업데이트가 필요한가요?💭 회고 (Optional)