Skip to content

Add Prime weapon skill support - #25

Open
Zaknzt wants to merge 1 commit into
Ivaar:masterfrom
Zaknzt:add-prime-weapon-skills
Open

Zaknzt wants to merge 1 commit into
Ivaar:masterfrom
Zaknzt:add-prime-weapon-skills

Conversation

@Zaknzt

@Zaknzt Zaknzt commented Sep 13, 2026

Copy link
Copy Markdown

Hi Ivaar — thank you for creating and maintaining SkillChains. This is my first upstream GitHub contribution, so apologies in advance if I’ve missed any preferred contribution conventions.

This is a deliberately small, data-only update adding the 14 Prime Weapon Skills and their skillchain properties to skills.weapon_skills. I have left Skillchains.lua, the existing addon version, and the rest of the project unchanged.

I also saw that @posimagi’s existing PR #22 already proposed Prime WS support. I do not want to take credit for or duplicate that work. Since that PR has accumulated some additional unrelated changes over time, I prepared this as a clean current-master patch containing only the Prime WS entries. If you would prefer to continue with #22 instead, please feel free to close this PR.

I validated the IDs and skillchain properties against current Windower resource data and tested the change in FFXI, including using Origin as an opening weapon skill, completing normal skillchain progression, and checking that legacy opener behavior continued to work.

All credit for SkillChains belongs to Ivaar and the existing contributors. This is only intended as a small compatibility update for current Prime Weapon Skills.

Thank you for considering it.

@zombie343

Copy link
Copy Markdown

I think Loonsies's chains has what you're looking for: https://github.com/loonsies/chains

@Zaknzt

Zaknzt commented Sep 14, 2026

Copy link
Copy Markdown
Author

Thanks for the pointer! I took a look at loonsies/chains. It looks like that project is the Ashita v4 rewrite, and it does already contain the Prime WS entries.

This PR is specifically for Ivaar’s current Windower SkillChains repository, where those entries are still missing. It’s also helpful as another cross-check on the IDs/properties, so I appreciate you pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants