Conversation
|
I think Loonsies's chains has what you're looking for: https://github.com/loonsies/chains |
Author
|
Thanks for the pointer! I took a look at loonsies/chains. It looks like that project is the Ashita v4 rewrite, and it does already contain the Prime WS entries. This PR is specifically for Ivaar’s current Windower SkillChains repository, where those entries are still missing. It’s also helpful as another cross-check on the IDs/properties, so I appreciate you pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ivaar — thank you for creating and maintaining SkillChains. This is my first upstream GitHub contribution, so apologies in advance if I’ve missed any preferred contribution conventions.
This is a deliberately small, data-only update adding the 14 Prime Weapon Skills and their skillchain properties to skills.weapon_skills. I have left Skillchains.lua, the existing addon version, and the rest of the project unchanged.
I also saw that @posimagi’s existing PR #22 already proposed Prime WS support. I do not want to take credit for or duplicate that work. Since that PR has accumulated some additional unrelated changes over time, I prepared this as a clean current-master patch containing only the Prime WS entries. If you would prefer to continue with #22 instead, please feel free to close this PR.
I validated the IDs and skillchain properties against current Windower resource data and tested the change in FFXI, including using Origin as an opening weapon skill, completing normal skillchain progression, and checking that legacy opener behavior continued to work.
All credit for SkillChains belongs to Ivaar and the existing contributors. This is only intended as a small compatibility update for current Prime Weapon Skills.
Thank you for considering it.