Remove JsonSerializable from EncodedImage - #1522
Merged
olivervogel merged 2 commits intoAug 24, 2026
Merged
Conversation
olivervogel
pushed a commit
that referenced
this pull request
Aug 24, 2026
* Remove JsonSerializable from EncodedImage * Tighten regression test comment and imports
Member
|
Yeah, maybe it's better this way. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonSerializable on EncodedImage (added in #1513) makes Laravel's response layer treat any encoded image as JSON content and rewrite the response Content-Type to application/json, breaking
return response($image->encode()), the most common way this library is used in HTTP contexts (also affects mewebstudio/captcha).Color, DataUri, and Resolution keep JsonSerializable since they aren't normally returned as raw HTTP bodies. EncodedImage is the one that regularly is, so this just drops the interface there.
Fixes #1521