Skip to content

Conversation

@lehins
Copy link
Collaborator

@lehins lehins commented Feb 7, 2026

Description

cardano-binary-1.7.3.0 has a breaking chnage introduced, therefore it has been deprecated on CHaP in IntersectMBO/cardano-haskell-packages#1240
This PR bumps the version to cardano-binary-1.8.0.0. It also updates versions in changelogs as part of postprocess release taht happened in IntersectMBO/cardano-haskell-packages#1227

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@lehins lehins requested review from a team and nfrisby as code owners February 7, 2026 06:29
@lehins lehins requested review from f-f and neilmayhew February 7, 2026 06:29
Copy link
Contributor

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess we need a release for cardano-binary@1.8.0.0 to CHaP as well?

I will close #619 since this replaces it

@lehins lehins force-pushed the lehins/deprecate-cardano-binary-1.7.3.0 branch 2 times, most recently from aeafc53 to c356f30 Compare February 8, 2026 09:01
@lehins
Copy link
Collaborator Author

lehins commented Feb 8, 2026

Looks good! I guess we need a release for cardano-binary@1.8.0.0 to CHaP as well?

Yes. Prepared a release: IntersectMBO/cardano-haskell-packages#1241

I will close #619 since this replaces it

Yeah, sorry, somehow didn't notice your PR. I've rebased this one on yours, to make sure I got your commit with the same changes into this one.

@neilmayhew
Copy link
Contributor

Maybe we could include #618 now

@lehins
Copy link
Collaborator Author

lehins commented Feb 9, 2026

Maybe we could include #618 now

Very good idea. Approved and set it to automerge.

@lehins lehins force-pushed the lehins/deprecate-cardano-binary-1.7.3.0 branch from c356f30 to cea9355 Compare February 9, 2026 18:10
@lehins lehins enabled auto-merge February 9, 2026 18:14
@lehins lehins force-pushed the lehins/deprecate-cardano-binary-1.7.3.0 branch from cea9355 to 00b47cc Compare February 9, 2026 18:30
@lehins lehins merged commit 9bd150f into master Feb 9, 2026
22 checks passed
@lehins lehins deleted the lehins/deprecate-cardano-binary-1.7.3.0 branch February 9, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants