Notorize macos executables#334
Open
paweljakubas wants to merge 6 commits intomasterfrom
Open
Conversation
Collaborator
Author
Collaborator
With official credentials this will be a lot harder. @johnalotoski would be the right person to talk to here. Due to the sensitivity involved and load on the SRE team, this isn't really something that can be solved quickly :-/ |
Collaborator
Author
|
@angerman sure! I will rebase the PR. Just wanted to prepare something that goes into this direction. I am leaving in your and Johns capable hands to prepare and "manage" secrets if there is appetite to support the macos notorization |
Requires secrets to be set in GitHub: - APPLE_CERTIFICATE - APPLE_CERTIFICATE_PASSWORD - APPLE_ID_USERNAME - APPLE_ID_PASSWORD - APPLE_TEAM_ID (as a variable, not secret)
6038a4f to
765c029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #321