fix(adr): use full slug in ADR-0005 superseded-by link#184
Merged
Conversation
log4brains parses the bracketed link text as the slug of the superseding ADR. `[0006]` is not a known slug, so `toAdr` is called without a superseder and throws "You forgot to pass the superseder", aborting the ADR site build and leaving `adr-site/` unwritten — which then breaks the Pages deploy at the `cp -r adr-site deploy/adr` step. Same shape as commit 77b5a3a; the fix is to spell out the full slug `0006-standard-builtindata-formats-with-json-type-dispatch` inside the brackets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[0006]link text in ADR-0005's status line and aborts the ADR site build, which then leaves thecp -r adr-site deploy/adrstep with nothing to copy.0006-standard-builtindata-formats-with-json-type-dispatch, mirroring the previous fix in 77b5a3a.Test plan
nix develop --command adr build --out ./adr-site --basePath /UPLC-CAPE/adrfinishes cleanly with all 12 ADRs generated and noFATALfrom log4brains.Deploy static content to Pagesworkflow onmainsucceeds and the published report's preview section shows Scalus alongside Plinth.