fix(Draft): We should remove signature+reply+forward when we check if the body is empty#2172
Open
valentinperignon wants to merge 1 commit intomasterfrom
Open
fix(Draft): We should remove signature+reply+forward when we check if the body is empty#2172valentinperignon wants to merge 1 commit intomasterfrom
valentinperignon wants to merge 1 commit intomasterfrom
Conversation
… the body is empty
|
There was a problem hiding this comment.
Pull request overview
This PR updates draft “emptiness” detection so that auto-appended HTML blocks (signature + reply/forward quotes) don’t count as user-entered content when deciding whether a draft is effectively empty.
Changes:
- Reworked
Draft.isEmptyOfUserChangesto remove appended HTML elements (signature/reply/forward quote nodes) before checking for remaining text. - Updated
Draft.shouldBeSavedto rely onisEmptyOfUserChanges(instead of only stripping the signature).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.