Skip to content

chore: Drop some legacy function#2923

Merged
baillyjamy merged 8 commits into
mainfrom
chore-update-core
May 29, 2026
Merged

chore: Drop some legacy function#2923
baillyjamy merged 8 commits into
mainfrom
chore-update-core

Conversation

@baillyjamy
Copy link
Copy Markdown
Contributor

@baillyjamy baillyjamy commented May 29, 2026

@baillyjamy baillyjamy requested review from a team and Copilot May 29, 2026 14:09
@github-actions github-actions Bot added the dependent This MR depends on another PR label May 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates several imports and XML view references from the deprecated com.infomaniak.core.legacy.* package to the new com.infomaniak.core.ui.* package (for EndIconTextInputLayout, setMargins/setMarginsRelative/setPaddingRelative, SnackbarUtils.showSnackbar, progress helpers, etc.). It depends on the corresponding android-core PR #785 which provides the replacements. It also drops the now-unused setPagination legacy import in SearchFragment and the unused androidx.core.view.marginStart import in AvatarNameEmailView.

Changes:

  • Replace legacy EndIconTextInputLayout XML references with com.infomaniak.core.ui.view.layout.EndIconTextInputLayout across 7 layout files.
  • Re-point Kotlin imports for margin/padding/progress/Snackbar helpers from com.infomaniak.core.legacy.utils.* to com.infomaniak.core.ui.view.extension.* / com.infomaniak.core.ui.view.utils.*.
  • Remove unused legacy imports (setPagination, marginStart).

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/src/main/res/layout/view_recipient_field.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/item_search_view.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/fragment_folder_picker.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/fragment_encryption_password.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/dialog_select_date_and_time.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/dialog_insert_link.xml Update EndIconTextInputLayout to new package
app/src/main/res/layout/bottom_sheet_restore_emails.xml Update EndIconTextInputLayout to new package
app/src/main/java/.../UnreadFolderItemView.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../IndentableFolder.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../DecoratedItemView.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../BannerWithActionView.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../AttachmentDetailsView.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../utils/extensions/Extensions.kt Switch showSnackbar import to core.ui
app/src/main/java/.../SyncOnboardingFragment.kt Switch setMargins import to core.ui
app/src/main/java/.../NewMessageFragment.kt Switch setMargins/showSnackbar imports to core.ui
app/src/main/java/.../AiPropositionFragment.kt Switch setMargins import to core.ui
app/src/main/java/.../AiPromptFragment.kt Switch setMargins/setMarginsRelative imports to core.ui
app/src/main/java/.../MessageAlertView.kt Switch progress helpers imports to core.ui
app/src/main/java/.../DownloadProgressDialog.kt Switch showSnackbar import to core.ui
app/src/main/java/.../ActionItemView.kt Switch margin/padding helpers to core.ui
app/src/main/java/.../SnackbarManager.kt Switch showSnackbar import to core.ui
app/src/main/java/.../SignatureSettingFragment.kt Switch showSnackbar import to core.ui
app/src/main/java/.../SearchFragment.kt Switch setMargins, drop unused setPagination import
app/src/main/java/.../RestoreEmailsBottomSheetDialog.kt Switch progress/Snackbar imports to core.ui
app/src/main/java/.../ThreadListFragment.kt Switch margin/padding/Snackbar imports to core.ui
app/src/main/java/.../ThreadListAdapter.kt Switch setMarginsRelative import to core.ui
app/src/main/java/.../AvatarNameEmailView.kt Switch setMarginsRelative import, drop unused marginStart import
app/src/main/java/.../NewAccountFragment.kt Switch showSnackbar import to core.ui
app/src/main/java/.../LoginFragment.kt Switch showSnackbar import to core.ui
app/src/main/java/.../BaseAlertDialog.kt Switch progress helpers imports to core.ui

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot removed the dependent This MR depends on another PR label May 29, 2026
@github-actions
Copy link
Copy Markdown

This PR/issue depends on:

@baillyjamy baillyjamy enabled auto-merge May 29, 2026 14:36
@sonarqubecloud
Copy link
Copy Markdown

@baillyjamy baillyjamy merged commit 9502118 into main May 29, 2026
10 checks passed
@baillyjamy baillyjamy deleted the chore-update-core branch May 29, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants