feat: Allow disabling kDrive display in ContentProvider#2015
Merged
Conversation
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
from
fb2ddb0 to
1cb1e52
Compare
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
2 times, most recently
from
0480d50 to
1cb1e52
Compare
aymericmariaux
requested review from
NicolasBourdin88 and
Copilot
and removed request for
NicolasBourdin88 and
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Security settings screen that lets users toggle whether kDrive’s DocumentsProvider is exposed to the system “Files” app (and other third‑party file pickers), and wires that screen into the existing Settings navigation.
Changes:
- Added “Show in Files” strings (with multiple localizations) and a new Security settings screen UI.
- Added a new
SecuritySettingsFragmentand navigation route fromSettingsFragment. - Implemented a persisted “provider disabled” flag in
CloudStorageProviderand enforced it inqueryChildDocuments()/openDocument().
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new strings for the “Show in Files” toggle and provider-disabled error. |
| app/src/main/res/values-*/strings.xml | Adds translations for the new provider toggle/error strings (sv/pt/pl/nl/nb/it/fr/fi/es/el/de/da). |
| app/src/main/res/navigation/main_navigation.xml | Adds navigation action from Settings to the new Security settings fragment; registers the fragment destination. |
| app/src/main/res/layout/fragment_settings_security.xml | New Security settings screen layout containing app lock and provider toggle. |
| app/src/main/res/layout/fragment_settings.xml | Replaces the previous “App Security” row with a chevron row leading to Security settings. |
| app/src/main/java/com/infomaniak/drive/ui/menu/settings/SettingsFragment.kt | Updates Settings click handling to navigate to the new Security settings screen. |
| app/src/main/java/com/infomaniak/drive/ui/menu/settings/SecuritySettingsFragment.kt | New fragment controlling app-lock entry and “Show in Files” provider toggle. |
| app/src/main/java/com/infomaniak/drive/ui/menu/settings/AppSecuritySettingsActivity.kt | Forces provider disable when enabling app lock. |
| app/src/main/java/com/infomaniak/drive/data/documentprovider/CloudStorageProvider.kt | Adds shared-pref flag + enforcement for disabled provider behavior and root refresh notifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
from
1dc00e4 to
473369a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
from
8e03fb9 to
0fac7ca
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
from
b4ac763 to
812f383
Compare
FabianDevel
changed the title
FabianDevel
requested changes
May 11, 2026
Prevents contentProviderSwitch from re-triggering its listener in onResume, avoiding redundant calls to CloudStorageProvider.setDisabled() and notifyRootsChanged().
…ing when disabled
… lock is disabled
Previously, the Content Provider was locked as soon as the app lock screen appeared, even if the user cancelled the password entry by pressing back. Now, the Content Provider is only locked if the lock process is completed successfully.
aymericmariaux
force-pushed
the
disable-kdrive-in-file-app
branch
from
11018e6 to
08be97a
Compare
FabianDevel
approved these changes
May 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.